Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inserting images via URL #5161

Closed
Reinmar opened this issue Aug 14, 2018 · 23 comments
Closed

Allow inserting images via URL #5161

Reinmar opened this issue Aug 14, 2018 · 23 comments
Assignees
Labels
Epic package:image squad:core Issue to be handled by the Core team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 14, 2018

The current (official) UI doesn't provide a way to insert an image via an URL. We've got a guide how to write a plugin which allows inserting an image via URL but no official way for doing this.

We discussed in the past how the UI of an "insert via URL or upload image" could look like in https://github.com/ckeditor/ckeditor5-image/issues/16.


If you'd like to see this feature implemented, please react with 👍 to this ticket.

@Reinmar Reinmar changed the title Allow inserting image via URL Allow inserting images via URL Aug 14, 2018
@Reinmar
Copy link
Member Author

Reinmar commented Aug 14, 2018

Another consideration is whether an image inserted via an URL should be automatically downloaded and uploaded to a service like Easy Image. That was discussed in e.g. https://github.com/ckeditor/ckeditor5-image/issues/211.

Such an option will ensure that no hotlinking (which is unsafe) takes place.

@Reinmar
Copy link
Member Author

Reinmar commented Aug 14, 2018

A DUP was reported in #1199.

@iyagicom
Copy link

In my case,
Downloading an image is meaningless.
I uploaded an image to keep it on the Google driver.
Also,
My server does not allow uploads.

@oleq
Copy link
Member

oleq commented Dec 18, 2018

Editing image URL would also make sense, as per #1401.

@rreynier
Copy link

Any update on this?

@mehrdadep
Copy link

hi, any update on inserting image via url?

@mlewand
Copy link
Contributor

mlewand commented May 21, 2019

@rreynier @mehrdadep Sorry for late reply, we'll try to tackle this during next iteration. Keep an eye on this issue to get updates.

@adamgasiorek
Copy link

adamgasiorek commented Jun 6, 2019

@mlewand some changes? it is really important feature

@adamgasiorek
Copy link

adamgasiorek commented Jun 6, 2019

https://ckeditor.com/docs/ckeditor5/latest/framework/guides/creating-simple-plugin.html#step-4-inserting-a-new-image
it looks okay, but doesnt work with react or angular :/

@AustinMutschler
Copy link

Is there any documentation on making the custom insert image by url work with React.

@sandibitenc
Copy link

It works just fine with Ract. Just implemented it in a custom build.

@khanhna
Copy link

khanhna commented Sep 29, 2019

For someone looking for this feature as bad as i do... I just made an UI embeded version of this, the idea was just basicly like https://ckeditor.com/docs/ckeditor5/latest/framework/guides/creating-simple-plugin.html#step-4-inserting-a-new-image.
only dropdown and UI when type in the url look just like the media embed.

Take a look here if you wish:
https://github.com/khanhna/ckeditor5-image-via-url

I don't validate the http and https or any restrict or something like that, add anything if you guys need yourself.

@azenkovets
Copy link

azenkovets commented Oct 2, 2019

@sandibitenc
Hi!
Did you have any issues with importing your custom build?
Could you please describe how when you imported your custom build?
I made a custom build according to this instruction - https://ckeditor.com/docs/ckeditor5/latest/builds/guides/development/custom-builds.html
But when i import my custom build (import ClassicEditor from '../utils/CkedtiorCustom' ) it breaks my application and the webserver stop running.

Thanks

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the next milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:image labels Oct 9, 2019
@piotr-mamenas
Copy link

Hey, so when is this functionality going to be available in Angular?

@HassanHashemi
Copy link

HassanHashemi commented Apr 7, 2020

Is this going to be implemented any time soon?
@Reinmar I was wondering if this release is aligned with our project time line.

@farid78epc

This comment has been minimized.

@mikekuss
Copy link

mikekuss commented May 7, 2020

would be great to have this!

@Reinmar Reinmar modified the milestones: iteration 34, iteration 35 Jul 27, 2020
@jodator jodator added the squad:core Issue to be handled by the Core team. label Jul 28, 2020
@panr panr self-assigned this Aug 7, 2020
@Reinmar
Copy link
Member Author

Reinmar commented Aug 20, 2020

I've just merged a guide describing how to enable this feature :) The release is planned next week.

@Reinmar Reinmar closed this as completed Aug 20, 2020
@rafalsk
Copy link

rafalsk commented Aug 23, 2020

https://twitter.com/gridnetproject we've been playing around with this recently as well, the feature enabling for images through URLs would be of utmost importance to us:-)

@dzpt
Copy link

dzpt commented Aug 30, 2020

@Reinmar have you released it?

@justlester
Copy link

Hi, I tried the feature based on the documentation,
https://ckeditor.com/docs/ckeditor5/latest/features/image.html#inserting-images-via-source-url

but it seems that the image package is not yet updated.

image

@mi1971
Copy link

mi1971 commented Sep 3, 2020

Same issue running ckeditor5@22.0.0. Release notes seem to indicate it should be there

@josephj
Copy link

josephj commented May 16, 2022

@Reinmar I have upgraded to 34.0.0 and it seems the issue is still there. There is no way to simply enable the insert image by URL without having the ImageUpload.

Screen Shot 2022-05-16 at 1 58 56 pm

The custom https://github.com/Aeness/ckeditor5-insert-image plugin is exactly what we need, but both the GPLv3 licence and version stop us from using it 😫.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic package:image squad:core Issue to be handled by the Core team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests