Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar button focus indication has too low contrast #5580

Closed
mlewand opened this issue Oct 14, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#250
Closed

Toolbar button focus indication has too low contrast #5580

mlewand opened this issue Oct 14, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#250
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. package:theme-lark support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mlewand
Copy link
Contributor

mlewand commented Oct 14, 2019

📝 Provide detailed reproduction steps (if any)

  1. Open an example editor with toolbar.
  2. Press alt + f10 to focus the toolbar.
  3. Examine focus outline color.

Eduitor UI with a button focused and a low contrast outline on a button

✔️ Expected result

The contrast ratio of the outline to background should meet at least WCAG level AA standard.

❌ Actual result

Contrast is too low and doesn't match WCAG level AA. It's 1.36:1 (#C5DAF8 to #FAFAFA).

📃 Other details

  • CKEditor version: 12.4.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed package:theme-lark domain:accessibility This issue reports an accessibility problem. labels Oct 14, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 14, 2019
@mlewand mlewand added the support:2 An issue reported by a commercially licensed client. label Oct 14, 2019
@mlewand
Copy link
Contributor Author

mlewand commented Oct 14, 2019

For anyone facing this issue there's a simple workaround that require you to add CSS like the following:

.ck-editor .ck.ck-button:active, .ck-editor .ck.ck-button:focus, .ck-editor a.ck.ck-button:active, .ck-editor a.ck.ck-button:focus {
	box-shadow: 0 0 0px 3px #1250A5;
}

You can see it here https://codepen.io/mlewand/pen/yLLOyME

@oleq oleq self-assigned this Oct 25, 2019
@oleq oleq modified the milestones: nice-to-have, iteration 28 Oct 25, 2019
jodator added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Oct 30, 2019
Fix: Enabled additional box-shadow on `.ck-button` to meet WCAG AA recommendations. Adjusted the color of the `--ck-color-focus-border` for the same reason (editables, widget selection, etc.). Closes ckeditor/ckeditor5#5580.

Also: 
* Optimized the color gird component for WCAG AA. 
* Imported insert table UI styles from ckeditor5-table (code refactoring).
   * Improved the table UI contrast and accessibility.

BREAKING CHANGE: The `--ck-color-focus-shadow` custom property is now `--ck-color-focus-outer-shadow`.
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Oct 30, 2019
Internal: Moved insert table UI theme styles to theme-lark (see ckeditor/ckeditor5#5580).
jodator added a commit to ckeditor/ckeditor5-ui that referenced this issue Oct 30, 2019
Internal: Updated the color tile checkbox icon for a better look, contrast, and accessibility (see ckeditor/ckeditor5#5580).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. package:theme-lark support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants