Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute element's priority 0 is treated as "no priority set" #5797

Closed
Reinmar opened this issue Nov 25, 2019 · 1 comment · Fixed by #9742
Closed

Attribute element's priority 0 is treated as "no priority set" #5797

Reinmar opened this issue Nov 25, 2019 · 1 comment · Fixed by #9742
Assignees
@mateuszzagorski
Labels
intro Good first ticket. package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 43 (v28...

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 25, 2019

This works fine:

const span = viewWriter.createAttributeElement( 'span', { class: 'foo' }, { priority: 1 } );

This has no effect on the order of attribute elements:

const span = viewWriter.createAttributeElement( 'span', { class: 'foo' }, { priority: 0 } );
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Nov 25, 2019
@Reinmar Reinmar added this to the nice-to-have milestone Nov 25, 2019
@Reinmar Reinmar added the intro Good first ticket. label Nov 25, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Nov 25, 2019

cc @scofalik

@mateuszzagorski mateuszzagorski self-assigned this May 19, 2021
@mateuszzagorski mateuszzagorski mentioned this issue May 21, 2021
Merged
@mlewand mlewand modified the milestones: nice-to-have, iteration 43 May 24, 2021
mlewand added a commit that referenced this issue May 25, 2021
@mlewand
Merge pull request #9742 from ckeditor/i/5797
7422073 
Fix (engine): Updated `downcastwriter` to allow setting up attribute element's priority to 0. Closes #5797.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateuszzagorski mateuszzagorski

Labels
intro Good first ticket. package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 43 (v28.0.0)
Development

Successfully merging a pull request may close this issue.

i/5797: Attribute element's priority now allowing value of 0 correctly ckeditor/ckeditor5
3 participants
@Reinmar @mlewand @mateuszzagorski