Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image toolbar for empty configuration #5857

Closed
jodator opened this issue Nov 28, 2019 · 0 comments · Fixed by #7408
Closed

Remove image toolbar for empty configuration #5857

jodator opened this issue Nov 28, 2019 · 0 comments · Fixed by #7408
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Nov 28, 2019

📝 Provide detailed reproduction steps (if any)

I think that the empty image toolbar shouldn't be displayed:

image

I was testing this in restricted editing mode in which image styles are needed to properly display the side image but the toolbar is not needed in this mode.

Removing this by removing the image toolbar plugin probably would fix that, but maybe the default behavior should be to not display the empty toolbar.

ps.: maybe log some warning also?

✔️ Expected result

The empty toolbar is not displayed

❌ Actual result

That's that arrow hanging if you select an image.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:image module:ux labels Nov 28, 2019
@mlewand mlewand added this to the nice-to-have milestone Dec 3, 2019
@Mgsy Mgsy modified the milestones: nice-to-have, backlog Dec 3, 2019
@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. and removed module:ux labels Jan 15, 2020
@Reinmar Reinmar changed the title remove image toolbar for empty configuration Remove image toolbar for empty configuration May 27, 2020
@jodator jodator modified the milestones: backlog, iteration 33 May 27, 2020
@pomek pomek self-assigned this Jun 9, 2020
jodator added a commit that referenced this issue Jun 10, 2020
Fix: The widget toolbar won't be shown if an empty collection of items was provided in the editor's configuration. Closes #5857.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants