Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor crashes when removing column #6789

Closed
niegowski opened this issue May 11, 2020 · 0 comments · Fixed by #6814
Closed

Editor crashes when removing column #6789

niegowski opened this issue May 11, 2020 · 0 comments · Fixed by #6814
Assignees
@niegowski
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 32 (v19...

Comments

@niegowski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

✔️ Expected result

❌ Actual result

ckeditorerror.js:66 Uncaught TypeError: Cannot read property 'parent' of null
    at Function._createBefore (position.js:977)
    at Function._createOn (range.js:893)
    at Ha.remove (writer.js:522)
    at Object.callback (tableutils.js:306)
    at xl._runPendingChanges (model.js:805)
    at xl.change (model.js:170)
    at Iw.execute (removecolumncommand.js:65)
    at Iw.<anonymous> (observablemixin.js:255)
    at Iw.fire (emittermixin.js:209)
    at Iw.<computed> [as execute] (observablemixin.js:259)

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: 19
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@niegowski niegowski added type:bug This issue reports a buggy (incorrect) behavior. package:table squad:table labels May 11, 2020
@jodator jodator added this to the next milestone May 12, 2020
@niegowski niegowski modified the milestones: next, iteration 32 May 13, 2020
@niegowski niegowski self-assigned this May 13, 2020
@niegowski niegowski mentioned this issue May 13, 2020
Merged
jodator added a commit that referenced this issue May 14, 2020
@jodator
Merge pull request #6814 from ckeditor/i/6789
84e3310 
Fix (table): Editor will do not crash when removing columns next to row-spanned cells. Closes #6789.
@jodator jodator mentioned this issue May 18, 2020
Closed
@mlewand mlewand mentioned this issue May 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 32 (v19.1.0)
Development

Successfully merging a pull request may close this issue.

#6789: Fixed removing column when there are multiple empty rows to remove. ckeditor/ckeditor5
2 participants
@jodator @niegowski