Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json should be indented with tabs #7

Closed
Reinmar opened this issue Jan 16, 2015 · 4 comments
Closed

package.json should be indented with tabs #7

Reinmar opened this issue Jan 16, 2015 · 4 comments
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Jan 16, 2015

No description provided.

@Reinmar Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Jan 16, 2015
@fredck
Copy link
Contributor

fredck commented Jan 16, 2015

The current formatting is on purpose.

The point is that npm install whatever --save-dev reformats package.json. It will be a pain in the *** to have to always reformat the code to our standards.

So, IMHO, for package.json, we should keep the npm install standards.

@Reinmar
Copy link
Member Author

Reinmar commented Jan 16, 2015

://////////////////////

Heh... ok.

@Reinmar Reinmar closed this as completed Jan 16, 2015
@Reinmar
Copy link
Member Author

Reinmar commented Jan 16, 2015

Actually, I'd prefer avoiding using npm install --save-dev, but I guess that no one will support me ;).

@fredck
Copy link
Contributor

fredck commented Jan 16, 2015

Actually, I'd prefer avoiding using npm install --save-dev, but I guess that no one will support me ;).

-1 straight :) especially because of version numbers but also because we must be ok with such so common practices.

@Reinmar Reinmar modified the milestone: 0.1.0 Mar 4, 2016
mlewand pushed a commit that referenced this issue May 1, 2020
Feature: Added the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin to the list of essential editor features (see #6536).
Talhafayyaz11 pushed a commit to Talhafayyaz11/ckeditor5 that referenced this issue Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants