Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gulp dependency #7040

Closed
jodator opened this issue Oct 11, 2017 · 3 comments
Closed

Remove gulp dependency #7040

jodator opened this issue Oct 11, 2017 · 3 comments
Labels
package:dev type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 13

Comments

@jodator
Copy link
Contributor

jodator commented Oct 11, 2017

This ticket is related to: #473.

I've found that gulp is used only in ckeditor-dev-docs package and it should be easily removed by using jsdoc directly.

Other thing to check is if we want remove gulp=util also. So far I've found that we only use gutil.colors so maybe using smaller library for CLI color would be better.
@ma2ciek
Copy link
Contributor

ma2ciek commented Oct 11, 2017 •
edited

Other thing to check is if we want remove gulp=util also. So far I've found that we only use gutil.colors so maybe using smaller library for CLI color would be better.

AFAIR we're using chalk as well.

@pomek
Copy link
Member

pomek commented Oct 11, 2017

Yes, in dev-env we are using chalk.

@jodator
Copy link
Contributor Author

jodator commented Oct 11, 2017 •
edited

We can use chalk directly for cli colors. (Forgot to push enter.)

Reinmar referenced this issue in ckeditor/ckeditor5-dev Nov 13, 2017
@Reinmar
Merge pull request #298 from ckeditor/t/296
723bee5 
Other: Removed gulp dependency across the whole project. Closes #296.

Now all packages use only npm scripts. Depending on usage you might either create a `"script"` entry in `pacakge.json` to invoke bin executables or require the library into a script.

* Package `ckeditor5-dev-env` exposes new `translations` binary.
* Package `ckeditor5-dev-tests` exposes new `test:manual` binary.
* Removed `gulp-jsdoc3` from `ckeditor5-dev-docs`. Now `jsdoc` is invoked directly.
* Removed `options` param from logger methods. Logger no longer uses `gutil.log` method.

BREAKING CHANGE: Gulp tasks were removed. New npm scripts were introduced.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-dev May 18, 2020
@mlewand mlewand added this to the iteration 13 milestone May 18, 2020
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:dev labels May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:dev type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 13
Development

No branches or pull requests
4 participants
@jodator @pomek @ma2ciek @mlewand