T/296: Remove gulp dependency. #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving gulp logger.
pomek
reviewed
Oct 13, 2017
| try { | ||
| tools.shExec( `${ cmd } -c ${ tmpConfig.name }`, { verbosity: 'info' } ); | ||
| } catch ( error ) { | ||
| return reject( 'Error during JSDoc generation.' ); |
There was a problem hiding this comment.
Would be nice to attach message from error. It should help understand what went wrong.
| @@ -34,6 +34,9 @@ | |||
| "node": ">=6.0.0", | |||
| "npm": ">=3.0.0" | |||
| }, | |||
| "bin": { | |||
There was a problem hiding this comment.
Why did you extract translations tasks from env/index.js?
There was a problem hiding this comment.
I could either leave it as is or create a bin script (translations). I didn't see a point of duplicating require().*Translation() in ckeditor5 repo.
This script accepts collect, upload or download param.
|
BTW, @jodator, please configure your editor to trim trailing whitespaces. |
|
@Reinmar double checked that now - currently I have this on. Might be off for some time as I've reset my editor settings during that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Remove gulp dependency. Closes #296.
Now all packages are independent of gulp. Depending on usage you might either create "script " entry in pacakge.json to invoke bin executables or require library into script.
ckeditor5-dev-envexposes newtranslationsbinary.gulp-jsdoc3from building API documentation. Nowjsdocis invoked directly.optionsparam from logger methods. Logger no longer usesgutil.logmethod.BREAKING CHANGE: Gulp is no longer required to run tasks from ckeditor5-dev-* packages use npm scripts instead.
BREAKING CHANGE: Gulp task are removed. New npm scripts were introduced.
Required for ckeditor/ckeditor5#602.