Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal line content styles look vintage #7418

Closed
oleq opened this issue Jun 10, 2020 · 0 comments 路 Fixed by #7443
Closed

Horizontal line content styles look vintage #7418

oleq opened this issue Jun 10, 2020 · 0 comments 路 Fixed by #7443
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:horizontal-rule squad:magic type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 33 (v20...

Comments

@oleq
Copy link
Member

oleq commented Jun 10, 2020

馃摑 Provide a description of the improvement

ATM

What it could look like

It helps especially when the fake caret around widgets (#6693) is displayed because:

  • the margin is bigger so there's more place to display the fake caret
  • the HR does not look like a fake caret

If you'd like to see this improvement implemented, add a 馃憤 reaction to this post.
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. domain:ui/ux This issue reports a problem related to UI or UX. package:horizontal-rule labels Jun 10, 2020
@oleq oleq self-assigned this Jun 16, 2020
@oleq oleq added this to the iteration 33 milestone Jun 16, 2020
@oleq oleq mentioned this issue Jun 16, 2020
Merged
oleq added a commit that referenced this issue Jun 18, 2020
@oleq
Merge pull request #7443 from ckeditor/i/7418-hr-styles
e8bff81 
Other (horizontal-line): Improved the look of horizontal lines in the editor content. Closes #7418.

Internal (theme-lark): Code refactoring in styles related to the horizontal line feature (see #7418).
@oleq oleq mentioned this issue Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:horizontal-rule squad:magic type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

#7418: Improved the look of horizontal lines in the editor content ckeditor/ckeditor5
2 participants
@Reinmar @oleq