placeholder text doesnt go away when block-element is inserted

[testbuddy]

📝 Provide detailed reproduction steps (if any)

1. Editor-data is set to ''
2. Set placeholder text in config
3. Insert block-element like image or custom widget

✔️ Expected result

data-placeholder attribute and ck-placeholder class are not set on the first block-element

❌ Actual result

data-placeholder attribute and ck-placeholder class are set on the first block-element

📃 Other details

• Browser: tested in chrome
• OS: windows
• CKEditor version: 5
• Installed CKEditor plugins:
  ckeditor5-react'
  inlineeditor'
  essentials'
  heading'
  bold'
  italic'
  underline'
  link'
  table'
  tabletoolbar'
  paragraph'
  image'
  imageupload'
  base64uploadadapter'
  imagetoolbar'
  imagecaption'
  imagestyle'
  imageresize'

[Mgsy]

Hi, we're aware of some problems with placeholders, e.g. while inserting a media and UI elements. However, I can't reproduce it with images. Could you describe more detailed steps to reproduce and create a screencast showing the issue?

[testbuddy]

Hi :)
Unfortunately i cannot showing a screencast cause some private code :(
Instead i try it with cutted screenshoots.

1. The data of the editor is empty ('') and the config object contains the key placeholder with value 'Type some text....'
   
2. Then i click the insert image button. This button is not modified. Just from the lib.
   
3. After the insert the figure element has the data-placeholder attribute.
   
4. When i insert a custom widget it also contains placeholder css class :(
   

Hopefully this helps ? This doesnt happend when i add text. Only the first block-element.

[Mgsy]

Thanks for the details. As it goes to data-placeholder attribute, it's added always to the first element in the editor. ck-placeholder class is not added to an image, so the placeholder doesn't display and it works properly.

As it comes to your custom widget, I believe the issue occurs because of problems mentioned in the tickets I've linked above. 

Out of curiosity - can you check if adding a change from ckeditor/ckeditor5-engine#1749 fixes your issue? After migrating to monorepo, this branch might be inaccessible, so you'll need to add a fix manually. Just add this code to ckeditor5-engine/src/view/placeholder.js after this line:

if ( element.getCustomProperty( 'widget' ) ) {
	return false;
}

[testbuddy]

Yeah this fix did it :)) Thanks for the fast help :)