Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder does not disappear after inserting media #1684

Closed
pomek opened this issue Apr 5, 2019 · 1 comment · Fixed by #7621 · May be fixed by ckeditor/ckeditor5-engine#1749
Closed

Placeholder does not disappear after inserting media #1684

pomek opened this issue Apr 5, 2019 · 1 comment · Fixed by #7621 · May be fixed by ckeditor/ckeditor5-engine#1749
Assignees
@oleq
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 34 (v21...

Comments

@pomek
Copy link
Member

pomek commented Apr 5, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Master and the latest release.

📋 Steps to reproduce

  1. Go to https://ckeditor.com/docs/ckeditor5/latest/features/editor-placeholder.html or use local build documentation.
  2. To the first editor (it must be empty), paste any URL to YT or add the media using the UI button.

✅ Expected result

Type the content here! should disappear.

❎ Actual result

But it does not:

image

📃 Other details that might be useful

I can reproduce it on Firefox, Chrome, and Safari.
@pomek pomek added the type:bug This issue reports a buggy (incorrect) behavior. label Apr 5, 2019
@pomek pomek added this to the iteration 24 milestone Apr 5, 2019
@mlewand mlewand modified the milestones: iteration 24, iteration 25 May 13, 2019
@jodator jodator self-assigned this Jun 18, 2019
@jodator jodator mentioned this issue Jun 19, 2019
Open
@Reinmar Reinmar modified the milestones: iteration 25, iteration 26 Jul 1, 2019
@mlewand mlewand modified the milestones: iteration 26, nice-to-have Jul 31, 2019
@Mgsy Mgsy mentioned this issue Dec 16, 2019
Closed
@Mgsy
Copy link
Member

Mgsy commented Dec 16, 2019 •
edited

Related #4114.

@Mgsy Mgsy mentioned this issue Apr 29, 2020
Closed
@Mgsy Mgsy mentioned this issue Jun 12, 2020
Closed
@jodator jodator removed their assignment Jun 22, 2020
@jodator jodator mentioned this issue Jun 22, 2020
Closed
@oleq oleq modified the milestones: nice-to-have, iteration 34 Jul 13, 2020
@oleq oleq mentioned this issue Jul 14, 2020
Merged
Reinmar added a commit that referenced this issue Jul 22, 2020
@Reinmar
Merge pull request #7621 from ckeditor/i/4469-view-raw-element
bff38e3 
Feature (engine): Implemented the view `RawElement`. Implemented the `DowncastWriter#createRawElement()` method. Closes #4469.

Fix (media-embed): The editor placeholder should disappear after inserting media into an empty editor. Closes #1684.

Docs (ckeditor5): Used the `RawElement` instead of `UIElement` in the "Using a React component in a block widget" guide (see #1684).

Internal (media-embed): Removed the `getFillerOffset()` hack from the `createMediaFigureElement()` helper that is no longer needed since the media content is rendered using `RawElements` (see #1684).

BREAKING CHANGE (engine): The `DomConverter#getParentUIElement()` method was renamed to `DomConverter#getHostViewElement()` because now it supports both `UIElement` and `RawElement` (see #4469).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 34 (v21.0.0)
6 participants
@Reinmar @jodator @oleq @pomek @mlewand @Mgsy