Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image resize outline flickers when pasting an image #8088

Closed
mlewand opened this issue Sep 16, 2020 · 1 comment · Fixed by #8108
Closed

Image resize outline flickers when pasting an image #8088

mlewand opened this issue Sep 16, 2020 · 1 comment · Fixed by #8108
Assignees
@mlewand
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 38 (v24...

Comments

@mlewand
Copy link
Contributor

mlewand commented Sep 16, 2020 •
edited
Loading

Also, besides image upload I can see that normal image paste (image copied from the editor) is affected too. The resize handles are repositioned with a long delay, even 300ms-500ms. This definitely didn't happen before. And as Fred checked, this is not related to WidgetTypeAround. You can even observe the glitch on this gif:

It'd be good to know WTH is happening there. Bisecting it might actually help a lot.

Originally posted by @Reinmar in #7548 (comment)
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. labels Sep 16, 2020
@mlewand mlewand added this to the iteration 36 milestone Sep 16, 2020
@mlewand
Copy link
Contributor Author

mlewand commented Sep 17, 2020

I checked it on imageresize.html (funny thing I wasn't able to repro this yesterday 😃) and here's what it looks like (resize handles greatly enlarged, to be visible):

@mlewand mlewand self-assigned this Sep 17, 2020
@mlewand mlewand mentioned this issue Sep 18, 2020
Merged
@Reinmar Reinmar modified the milestones: iteration 36, iteration 37 Sep 28, 2020
@mlewand mlewand mentioned this issue Sep 30, 2020
Closed
@Reinmar Reinmar modified the milestones: iteration 37, iteration 38 Oct 26, 2020
@AnnaTomanek AnnaTomanek changed the title Image resize outline flickers during when pasting an image Image resize outline flickers when pasting an image Oct 30, 2020
@AnnaTomanek AnnaTomanek mentioned this issue Oct 30, 2020
Closed
Reinmar added a commit that referenced this issue Nov 4, 2020
@Reinmar
Merge pull request #8108 from ckeditor/i/7548
021227d 
Fix (link): Fixed a quick image flicker of image resize frame when inserting an image. Closes #8088.

Other (widget): `WidgetResize#visibleResizer` and `WidgetResize#getResizerByViewElement()` are now public. See #8088.

Other (widget): `WidgetResize` will now automatically set `WidgetResize#visibleResizer` when calling `WidgetResize#attachTo()` if the corresponding resizer's element is focused during the call. See #8088.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Fixed a quick image flicker of image resize frame when inserting an image ckeditor/ckeditor5
2 participants
@Reinmar @mlewand