Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing backspace at the beginning of the first block should reset it to a paragraph #8137

Closed
Reinmar opened this issue Sep 24, 2020 · 4 comments · Fixed by #8569
Closed

Pressing backspace at the beginning of the first block should reset it to a paragraph #8137

Reinmar opened this issue Sep 24, 2020 · 4 comments · Fixed by #8569
Assignees
@niegowski
Labels
intro Good first ticket. package:typing squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 39 (v25...

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 24, 2020

📝 Provide detailed reproduction steps (if any)

Pressing backspace here should turn the first line into a paragraph.

✔️ Expected result

The first line is turned into a paragraph.

❌ Actual result

The first line remains a heading.

📃 Other details

We already support pressing Backspace in this case (when the editor is empty):

<root>
	<heading1>[]</heading1>
</root>

But to me, it does not really matter what's in the next line. When I press backspace here I'd expect to see a paragraph. 

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. package:typing type:improvement This issue reports a possible enhancement of an existing feature. squad:core Issue to be handled by the Core team. labels Sep 24, 2020
@jodator
Copy link
Contributor

jodator commented Sep 24, 2020

Pressing backspace here should turn the first line into a paragraph.

Annoying as hell 😄

@Reinmar
Copy link
Member Author

Reinmar commented Oct 8, 2020

Why? If it happens only in the first block of the editor. I don't mean implementing Notion's behavior when it happens in every block.

@jodator
Copy link
Contributor

jodator commented Oct 8, 2020

Why? If it happens only in the first block of the editor. I don't mean implementing Notion's behavior when it happens in every block.

I meant that the current behavior is annoying. I'm all-in for the change.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 16, 2020

Strongly related scenario: #7636.

@Reinmar Reinmar mentioned this issue Oct 16, 2020
Closed
@mlewand mlewand added this to the backlog milestone Nov 2, 2020
@Reinmar Reinmar added the intro Good first ticket. label Nov 9, 2020
@Reinmar Reinmar changed the title Pressing backspace at the beginning of first block should reset it to a paragraph Pressing backspace at the beginning of the first block should reset it to a paragraph Nov 16, 2020
@niegowski niegowski self-assigned this Dec 1, 2020
@Reinmar Reinmar modified the milestones: backlog, iteration 39 Dec 2, 2020
@niegowski niegowski mentioned this issue Dec 2, 2020
Merged
@niegowski niegowski modified the milestones: iteration 39, iteration 38 Dec 2, 2020
@Reinmar Reinmar modified the milestones: iteration 38, iteration 39 Dec 4, 2020
@AnnaTomanek AnnaTomanek mentioned this issue Dec 16, 2020
Closed
Reinmar added a commit that referenced this issue Dec 22, 2020
@Reinmar
Merge pull request #8569 from ckeditor/i/8137
2d9954c 
Feature (typing): Empty block element at the beginning of the limit element should be converted to a paragraph on backspace key press. Closes #8137.

Feature (block-quote): Block-quote should be split on backspace key press at the beginning of the block-quote. Closes #7636.

Fix (list): The `delete` event handler listening on a higher priority to avoid intercepting by the block-quote and widget handler. Closes #8706.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
intro Good first ticket. package:typing squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
4 participants
@Reinmar @jodator @niegowski @mlewand