Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting list inside other list results in two list types on the same level #8160

Closed
jodator opened this issue Sep 25, 2020 · 2 comments · Fixed by #8354
Closed

Pasting list inside other list results in two list types on the same level #8160

jodator opened this issue Sep 25, 2020 · 2 comments · Fixed by #8354
Assignees
Labels
package:list squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Sep 25, 2020

📝 Provide detailed reproduction steps (if any)

  1. Create a two-level list.
  2. Set level two style to bulleted list style (ie circles).
  3. Create a second list with numbered list styles (ie roman).
  4. Select & copy the second list.
  5. Put caret inside the first list item on level two of the first list.
  6. Paste.

✔️ Expected result

The styles are set to the same list style & type on every list item from level two.

❌ Actual result

The items pasted after the selected list item have their styles retained.

You cannot have this effect using UI and changin list styles as we change all items on the same level when changing list style of one item (second part of the above GIF).

📃 Other details

  • CKEditor version: master @ iteration 36
  • Installed CKEditor plugins: ListStyles

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:list squad:core Issue to be handled by the Core team. labels Sep 25, 2020
@Reinmar
Copy link
Member

Reinmar commented Sep 28, 2020

Uh, good that you spotted this :) Let's fix it in it37.

@AnnaTomanek AnnaTomanek added this to the iteration 38 milestone Oct 26, 2020
@pomek
Copy link
Member

pomek commented Oct 27, 2020

What are the expected results?

EDIT: Ok, I see. You want to force changing the listType attribute for all pasted items.

@pomek pomek self-assigned this Oct 27, 2020
jodator added a commit that referenced this issue Oct 28, 2020
Fix (list): List styles will be inherited correctly when pasting a list into another list. Closes #8160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:list squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants