Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save an HTML embed after pasting a text from the editor #8328

Closed
Mgsy opened this issue Oct 23, 2020 · 3 comments · Fixed by #8478
Closed

Can't save an HTML embed after pasting a text from the editor #8328

Mgsy opened this issue Oct 23, 2020 · 3 comments · Fixed by #8478
Assignees
Labels
package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Mgsy
Copy link
Member

Mgsy commented Oct 23, 2020

📝 Provide detailed reproduction steps (if any)

  1. Insert a new HTML embed/edit the existing one.
  2. Select some text in the editor.
  3. Copy it.
  4. Paste it to the HTML embed.
  5. Save changes.

✔️ Expected result

Changes are saved.

❌ Actual result

Nothing happens.

📃 Other details


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. package:html-embed labels Oct 23, 2020
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Oct 23, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Oct 23, 2020
@pomek
Copy link
Member

pomek commented Oct 23, 2020

The same kind of error (missing selection on the widget element).

  1. Insert an empty widget.
  2. Use widget type around mechanism, insert a paragraph below.
  3. Insert a second widget.
  4. Click the first textarea.
  5. Type whatever.
  6. After saving changes, the second container will be modified.

image

@AnnaTomanek AnnaTomanek modified the milestones: nice-to-have, iteration 38 Oct 26, 2020
@pkwasnik
Copy link
Contributor

pkwasnik commented Nov 5, 2020

Another similar case:

  1. Insert or edit widget (do not save)
  2. Click anywhere outside the widget
  3. Try to save
  4. Nothing happen

EDIT:

and another one, also connected with #8357 

  1. Inset HTML embed widged
  2. Enter readonly mode
  3. edit button should be disabled, but isn't

@psmyrek
Copy link
Contributor

psmyrek commented Nov 23, 2020

I've created a follow-up #8509 to provide a generic solution for selecting a widget, which has the data-cke-ignore-events attribute.

niegowski added a commit that referenced this issue Nov 23, 2020
Fix (html-embed): Fixed saving the widget content after it lost the selection. Closes #8328.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants