Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML embed editing UI is broken when editor uses an RTL language #8335

Closed
oleq opened this issue Oct 23, 2020 · 0 comments · Fixed by #8535
Closed

HTML embed editing UI is broken when editor uses an RTL language #8335

oleq opened this issue Oct 23, 2020 · 0 comments · Fixed by #8535
Assignees
@niegowski
Labels
domain:rtl This issue reports a problem with support for right-to-left languages. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 38 (v24...

Comments

@oleq
Copy link
Member

oleq commented Oct 23, 2020

📝 Provide detailed reproduction steps (if any)

  1. Go to the HTML embed manual test.
  2. Put language: 'ar' in editor config.
  3. Edit an embed.

✔️ Expected result

❌ Actual result

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. release:potential-blocker This issue potentially blocks the upcoming release (should be checked). package:html-embed labels Oct 23, 2020
@oleq oleq changed the title HTML embed editing UI is broken when editor uses a RTL language HTML embed editing UI is broken when editor uses an RTL language Oct 23, 2020
@oleq oleq added this to the backlog milestone Oct 23, 2020
@Reinmar Reinmar removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Oct 26, 2020
@Reinmar Reinmar modified the milestones: backlog, nice-to-have Oct 26, 2020
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Oct 26, 2020
@oleq oleq added the domain:rtl This issue reports a problem with support for right-to-left languages. label Oct 26, 2020
@AnnaTomanek AnnaTomanek modified the milestones: nice-to-have, iteration 38 Oct 26, 2020
@niegowski niegowski self-assigned this Nov 26, 2020
@niegowski niegowski mentioned this issue Nov 26, 2020
Merged
oleq added a commit that referenced this issue Nov 30, 2020
@oleq
Merge pull request #8535 from ckeditor/i/8335
1ac756a 
Fix (html-embed): HTML embed editing UI should not be broken when the editor uses an RTL language. Closes #8335.

Fix (theme-lark): HTML embed editing UI should not be broken when the editor uses an RTL language (see #8335). 

Feature (ui): Added support for a new south-east position of the `TooltipView` (see #8335).

Feature (theme-lark): Added styles for a new south-east position of the `TooltipView` (see #8335).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:rtl This issue reports a problem with support for right-to-left languages. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Added support for RTL in html-embed. ckeditor/ckeditor5
4 participants
@Reinmar @AnnaTomanek @oleq @niegowski