Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing tests for the entire repository fail #8571

Closed
pomek opened this issue Dec 3, 2020 · 1 comment Β· Fixed by #8969
Closed

Executing tests for the entire repository fail #8571

pomek opened this issue Dec 3, 2020 · 1 comment Β· Fixed by #8969
Assignees
Labels
domain:dx This issue reports a developer experience problem or possible improvement. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented Dec 3, 2020

πŸ“ Provide detailed reproduction steps (if any)

  1. yarn test --reporter=dots --repositories=ckeditor5

βœ”οΈ Expected result

Green results.

❌ Actual result

Chrome 86.0.4240.198 (Mac OS 10.15.7) ImageResizeHandles command disables the resizer if the command is disabled FAILED
	TypeError: Cannot read property 'isEnabled' of undefined
	    at Context.eval (webpack:///./packages/ckeditor5-image/tests/imageresize/imageresizehandles.js?:117:20)

Chrome 86.0.4240.198 (Mac OS 10.15.7) ImageResizeHandles command the resizer is disabled from the beginning when the command is disabled when the image is inserted FAILED
	TypeError: Cannot read property 'isEnabled' of undefined
	    at Context.eval (webpack:///./packages/ckeditor5-image/tests/imageresize/imageresizehandles.js?:142:20)

Chrome 86.0.4240.198 (Mac OS 10.15.7) ImageResizeHandles undo integration has correct border size after undo FAILED
	AssertionError: expected '' to equal '120px'
	    at Context.eval (webpack:///./packages/ckeditor5-image/tests/imageresize/imageresizehandles.js?:210:45)

Chrome 86.0.4240.198 (Mac OS 10.15.7) ImageResizeHandles widget toolbar integration visibility after the resize was canceled FAILED
	TypeError: Cannot read property 'cancel' of undefined
	    at Context.eval (webpack:///./packages/ckeditor5-image/tests/imageresize/imageresizehandles.js?:447:12)

Chrome 86.0.4240.198 (Mac OS 10.15.7) MentionUI typing integration asynchronous list with custom trigger should fire requestFeed:response when request feed return a response FAILED
	AssertError: expected spy to be called once but was called 0 times
	    at Object.fail (node_modules/sinon/pkg/sinon.js:158:25)
	    at failAssertion (node_modules/sinon/pkg/sinon.js:115:20)
	    at Object.assert.<computed> [as calledOnce] (node_modules/sinon/pkg/sinon.js:141:17)
	    at eval (webpack:///./packages/ckeditor5-mention/tests/mentionui.js?:990:20)
Chrome 86.0.4240.198 (Mac OS 10.15.7): Executed 15549 of 15572 (5 FAILED) (skipped 23) (4 mins 2.65 secs / 1 min 23.992 secs)

πŸ“ƒ Other details

  • Browser: Chrome 86.0.4240.198
  • OS: MacOS
  • CKEditor version: Latest #release branch

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@pomek pomek added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 3, 2020
@Reinmar Reinmar added this to the backlog milestone Dec 7, 2020
@oleq
Copy link
Member

oleq commented Jan 21, 2021

AFAIR this is related to editor focus. When you run tests and don't touch the computer they pass. If you do something at that time – they will fail. That's why they pass on CI.

There's probably some editing root focus call missing in tests.

@oleq oleq self-assigned this Feb 2, 2021
@oleq oleq added domain:dx This issue reports a developer experience problem or possible improvement. squad:dx labels Feb 2, 2021
@oleq oleq modified the milestones: backlog, iteration 40 Feb 2, 2021
oleq added a commit that referenced this issue Feb 17, 2021
…tests

Tests (image, widget): The `ImageResizeHandles` tests should not fail when the browser window is blurred. Closes #8571.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
3 participants