Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify possibility to remove more things from DLL. #8594

Closed
jodator opened this issue Dec 7, 2020 · 3 comments
Closed

Verify possibility to remove more things from DLL. #8594

jodator opened this issue Dec 7, 2020 · 3 comments
Assignees
@jodator
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 39 (v25...

Comments

@jodator
Copy link
Contributor

jodator commented Dec 7, 2020

Provide a description of the task

At the moment, in #8517 we have a DLL mega build with all the editors creators inside. Let's check if we can move even more packages outside the DLL and the sample work as it works now.
@jodator jodator added type:task This issue reports a chore (non-production change) and other types of "todos". squad:dx labels Dec 7, 2020
@jodator jodator added this to the iteration 39 milestone Dec 7, 2020
@jodator jodator self-assigned this Dec 7, 2020
@jodator
Copy link
Contributor Author

jodator commented Dec 7, 2020

@Reinmar It looks like we could safely remove base editors from the DLL (2073b09) by:

  1. Making base editor use imports from ckeditor5.
  2. Making the editor DLL-compatible build import form the editor base.
  3. Exposing more API in the utils, core, ui, eninge .

ATM I've doubled the window.CKEditor5.ClassicEditor because there are two collading builds:

  1. The ckeditor5-editor-classic build.
  2. The ckeditor5-dll-classic (it bundles 1) build.

@jodator jodator mentioned this issue Dec 7, 2020
Merged
@jodator
Copy link
Contributor Author

jodator commented Dec 7, 2020

I've successfully removed all the editor builds from the DLL build.

pomek added a commit that referenced this issue Dec 8, 2020
@pomek
Merge pull request #8595 from ckeditor/i/8594
429846f 
Internal: Remove base editors from the editor build. Closes #8594.
@pomek
Copy link
Member

pomek commented Dec 8, 2020

Closed with 429846f.

@pomek pomek closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

No branches or pull requests
2 participants
@jodator @pomek