Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to select horizontal line and page break when no other widget plugins are installed #8825

Closed
maxbarnas opened this issue Jan 13, 2021 · 2 comments · Fixed by #8827
Closed

Unable to select horizontal line and page break when no other widget plugins are installed #8825

maxbarnas opened this issue Jan 13, 2021 · 2 comments · Fixed by #8827
Assignees
@maxbarnas
Labels
package:horizontal-rule squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 39 (v25...

Comments

@maxbarnas
Copy link
Contributor

maxbarnas commented Jan 13, 2021 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

Horizontal line

Screen.Recording.2021-01-13.at.12.07.08.mov
  1. Configure online build with horizontal line plugin.
  2. Open sample.html.
  3. Add a horizontal line and try to select it

Page break

Screen.Recording.2021-01-13.at.13.16.03.mov
  1. Configure online build with page break plugin.
  2. Open sample.html.
  3. Add a page break and try to select it

✔️ Expected result

Horizontal line/page break is selected.

❌ Actual result

Unable to select horizontal line/page break.

📃 Other details

  • Installed CKEditor plugins: HorizontalLine/PageBreak.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@maxbarnas maxbarnas added type:bug This issue reports a buggy (incorrect) behavior. package:horizontal-rule squad:core Issue to be handled by the Core team. labels Jan 13, 2021
@maxbarnas maxbarnas added this to the iteration 39 milestone Jan 13, 2021
@maxbarnas maxbarnas self-assigned this Jan 13, 2021
@maxbarnas maxbarnas mentioned this issue Jan 13, 2021
Merged
@oleq
Copy link
Member

oleq commented Jan 13, 2021 •
edited
Loading

What about Page break? Looks like it has the same problem. Let's handle both of them here.

@maxbarnas maxbarnas changed the title Unable to select horizontal line when no other widget plugins are installed Unable to select horizontal line and page break when no other widget plugins are installed Jan 13, 2021
@maxbarnas
Copy link
Contributor Author

maxbarnas commented Jan 13, 2021 •
edited
Loading

What about Page break? Looks like it has the same problem. Let's handle both of them here.

Somehow I didn't register the Page break at first. Thanks for pointing it out. Both examples of the issue, as well as fixes, are provided now.

oleq added a commit that referenced this issue Jan 13, 2021
@oleq
Merge pull request #8827 from ckeditor/i/8825
9f26d2b 
Fix (horizontal-line): The horizontal line feature should require the `Widget` plugin. Closes #8825.

Fix (page-break): The page break feature should require the `Widget` plugin. Closes #8825.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxbarnas maxbarnas

Labels
package:horizontal-rule squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
2 participants
@oleq @maxbarnas