Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs builder should allow to override EventInfo with other class #9069

Closed
niegowski opened this issue Feb 22, 2021 · 4 comments
Closed
Labels
resolution:expired This issue was closed due to lack of feedback. squad:devops Issue to be handled by the Devops team. status:stale type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@niegowski
Copy link
Contributor

Provide a description of the task

This is a follow-up for #9023 where we introduced BubblingEventInfo but there is no way to alter the API docs to inform about this class used instead of EventInfo while describing an event.

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@niegowski niegowski added type:task This issue reports a chore (non-production change) and other types of "todos". squad:devops Issue to be handled by the Devops team. labels Feb 22, 2021
@niegowski
Copy link
Contributor Author

Seems that https://github.com/ckeditor/ckeditor5-dev/blob/master/packages/jsdoc-plugins/lib/event-extender/event-extender.js#L25-L33 should extend the params list only if the first param name is not eventInfo.

@ma2ciek
Copy link
Contributor

ma2ciek commented Feb 23, 2021

Seems that https://github.com/ckeditor/ckeditor5-dev/blob/master/packages/jsdoc-plugins/lib/event-extender/event-extender.js#L25-L33 should extend the params list only if the first param name is not eventInfo.

Actually, I feel that all our events should declare all arguments on which the callback is called. But this is probably undoable as there are observables and other weird CKEditor 5 constructs 😄

@event foo
@param {BubblingEventInfo} eventInfo
@param {*} data
@event bar
@param {EventInfo} eventInfo
@param {*} data

So perhaps we can implement it as you suggested.

@Reinmar Reinmar added this to the nice-to-have milestone Mar 15, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 13, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:expired This issue was closed due to lack of feedback. squad:devops Issue to be handled by the Devops team. status:stale type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

5 participants