Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a linter rule that will disallow adding cross-package imports in the ckeditor5-watchdog package #9318

Closed
ma2ciek opened this issue Mar 22, 2021 · 2 comments · Fixed by ckeditor/eslint-plugin-ckeditor5-rules#9
Closed

Create a linter rule that will disallow adding cross-package imports in the ckeditor5-watchdog package #9318

ma2ciek opened this issue Mar 22, 2021 · 2 comments · Fixed by ckeditor/eslint-plugin-ckeditor5-rules#9
Assignees
@przemyslaw-zan
Labels
squad:devops Issue to be handled by the Devops team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 48 (v31...

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Mar 22, 2021

A follow-up to #9315.

We need to disallow cross-package imports in the ckeditor5-watchdog package as this might lead to duplication errors in our integrations (see #9315).

The information should be also added to our docs.
@ma2ciek ma2ciek added type:improvement This issue reports a possible enhancement of an existing feature. squad:devops Issue to be handled by the Devops team. labels Mar 22, 2021
@Reinmar
Copy link
Member

Reinmar commented Mar 22, 2021

In #9315 we decided to simply remove that dependency for now.

@mlewand mlewand added this to the unknown milestone May 17, 2021
@pomek
Copy link
Member

pomek commented Oct 6, 2021

Scope:

Helpful resources:

@pomek pomek modified the milestones: unknown, backlog Oct 6, 2021
@pomek pomek modified the milestones: backlog, iteration 48 Oct 11, 2021
This was referenced Oct 13, 2021
Merged
Merged
pomek added a commit to ckeditor/eslint-plugin-ckeditor5-rules that referenced this issue Oct 15, 2021
@pomek
Merge pull request #9 from ckeditor/ck/9318
d588b8c 
Feature: Created a new rule that disallows importing modules from CKEditor 5 packages. Closes ckeditor/ckeditor5#9318.
pomek added a commit to ckeditor/eslint-config-ckeditor5 that referenced this issue Oct 15, 2021
@pomek
Merge pull request #2 from ckeditor/ck/9318
e113b38 
Other: Enabled the `ckeditor5-rules/no-cross-package-imports` rule that disallows importing modules from CKEditor 5 packages inside the `@ckeditor/ckeditor5-watchdog` package. See: ckeditor/ckeditor5#9318.
@przemyslaw-zan przemyslaw-zan mentioned this issue Oct 18, 2021
Merged
pomek added a commit that referenced this issue Oct 18, 2021
@pomek
Merge pull request #10709 from ckeditor/ck/9318
86f4456 
Docs: Added explanation for the "ckeditor5-rules/no-cross-package-imports" rule. See #9318.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslaw-zan przemyslaw-zan

Labels
squad:devops Issue to be handled by the Devops team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 48 (v31.0.0)
5 participants
@Reinmar @pomek @ma2ciek @mlewand @przemyslaw-zan