Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the image style "full" to "block". #9545

Closed
magda-chrzescian opened this issue Apr 22, 2021 · 2 comments
Closed

Rename the image style "full" to "block". #9545

magda-chrzescian opened this issue Apr 22, 2021 · 2 comments
Assignees
@magda-chrzescian
Labels
intro Good first ticket. package:image squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 44 (v29...

Comments

@magda-chrzescian
Copy link
Contributor

Provide a description of the task

The name "full" doesn't reflect, how the image will be actually displayed. If the image's original size is less than the editor's width, it is displayed in the middle of the editing area in its original size. Since we are making so many breaking changes implementing the inline images, it seems to be a good moment to fix this name.

The image style name should be changed in the builds, manual and automatic tests, internal and CF projects.
This change should be mentioned in #9339.

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@magda-chrzescian magda-chrzescian added type:task This issue reports a chore (non-production change) and other types of "todos". package:image squad:core Issue to be handled by the Core team. labels Apr 22, 2021
@magda-chrzescian magda-chrzescian added this to the iteration 43 milestone Apr 22, 2021
@magda-chrzescian
Copy link
Contributor Author

There will be some missing translations due to these changes.

@mlewand mlewand added the intro Good first ticket. label May 27, 2021
@magda-chrzescian magda-chrzescian self-assigned this Jun 11, 2021
@magda-chrzescian magda-chrzescian mentioned this issue Jun 17, 2021
Merged
@magda-chrzescian magda-chrzescian changed the title Rename the image style "full" to "original". Rename the image style "full" to "block". Jun 21, 2021
oleq added a commit that referenced this issue Jun 21, 2021
@oleq
Merge pull request #9896 from ckeditor/ck/9545-renaming-full-style
b5908e5 
Other (image): The default image style is now called `block`, instead of `full`. Its label reads now "Centered image" and it is represented by the appropriate icon in the image toolbar. See #9545.
@oleq
Copy link
Member

oleq commented Jun 21, 2021

Closed in #9896.

@oleq oleq closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
intro Good first ticket. package:image squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 44 (v29.0.0)
Development

No branches or pull requests
4 participants
@AnnaTomanek @oleq @mlewand @magda-chrzescian