Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell border color is not correct when changing default Border style #9790

Open
108signals opened this issue May 29, 2021 · 11 comments
Open

Cell border color is not correct when changing default Border style #9790

108signals opened this issue May 29, 2021 · 11 comments
Labels
pending:feedback This issue is blocked by necessary feedback. squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@108signals
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Select one or more cells
  2. Select cell properties
  3. Change Border style to Solid (or any other value).

✔️ Expected result

When the border style is changed don't set border color and width until user chooses to do so.

❌ Actual result

Cell(s) border color is changed to black and width of 3px; however, the modal values for border color and width are not changed.

📃 Other details

  • Browser: Safari
  • OS: MacOS 11.2.3
  • First affected CKEditor version: on your demo website
  • Installed CKEditor plugins: on your demo website
@108signals 108signals added the type:bug This issue reports a buggy (incorrect) behavior. label May 29, 2021
@108signals
Copy link
Author

There are additional issues related to cell properties that make this buggy. For example when users set a cell border to solid, black, and 1px it doesn't get applied on all sides of the cell.

image

@108signals
Copy link
Author

108signals commented May 29, 2021

Additional issues with border styles in video

Border.Style.Issues.mp4

@pomek
Copy link
Member

pomek commented May 30, 2021

✔️ Expected result

When the border style is changed don't set border color and width until user chooses to do so.

This was fixed in #9555. Could you verify it on our nightly docs?

@pomek pomek added the pending:feedback This issue is blocked by necessary feedback. label May 30, 2021
@108signals
Copy link
Author

@pomek thanks for the heads up that this was resolved. I checked the nightly build demo site and while better there are still issues. See the attached video

Screen.Recording.2021-06-02.at.10.47.25.AM.mov

@mlewand mlewand added the support:2 An issue reported by a commercially licensed client. label Jun 5, 2021
@magda-chrzescian
Copy link
Contributor

It seems that the posted issue is caused by the default mechanism of rendering overlapping borders.

When it comes to the table cell collapsed borders, the wider border is always rendered on top. If borders have the same width, the order of the elements counts - that's why the cells on the right and below the selected one don't cover it.

Since the z-index property won't be helpful here, it seems that we have to reset the borders of the adjacent cells (they're set to 1px solid gray for the whole table in the content styles) to display properly the 1px border which was set manually.

@mlewand
Copy link
Contributor

mlewand commented Jun 7, 2021

Isn't this problem something that can be fixed by setting border-collapse: separate; CSS style?

Edit I applied this CSS and repeated steps from #9790 (comment) - the borders looks better:

@magda-chrzescian
Copy link
Contributor

Isn't this problem something that can be fixed by setting border-collapse: separate; CSS style?

It solves this problem, but at the same time changes the behavior of the cell border dramatically.

In this case, borders are always duplicated, so applying a border to adjacent cells makes it 2 times wider between the cells. There is also no possibility to make the border 1px wide - next to the black line, there is always a gray one from the adjacent cell.

image

I'm not saying that it isn't a way to go, but we should be aware of the consequences. It obviously can be fixed this way by the integrator by applying mentioned border-collapse: separate; rule in the .ck-content .table table selector.

@108signals
Copy link
Author

@magda-chrzescian wanted to check in and see if you have any updates on this issue

@108signals
Copy link
Author

@magda-chrzescian @mlewand wanted to check in on this issue and see if there are any updates. thank you

@katypodbielski
Copy link

Hi CKE Team, I'm writing to see if there are any updates on this issue? Our users continue to flag and follow-up about this ticket. Resolving would improve the experience of using tables. Thank you

@maxbarnas @pomek @magda-chrzescian @mdabkowska88 @mlewand

@ckeditor ckeditor deleted a comment from martynawierzbicka Oct 12, 2022
@108signals
Copy link
Author

Hi CKE team, wanted to see if there's any updates to this issue. We get many customer issues related to this.

@maxbarnas @pomek @magda-chrzescian @mdabkowska88 @mlewand

@ckeditor ckeditor deleted a comment from 108signals Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending:feedback This issue is blocked by necessary feedback. squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants