Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved model.TreeWalker#next() efficiency #11463

Merged
merged 1 commit into from Mar 28, 2022
Merged

Improved model.TreeWalker#next() efficiency #11463

merged 1 commit into from Mar 28, 2022

Conversation

scofalik
Copy link
Contributor

Suggested merge commit message (convention)

Other (engine): Improved `model.TreeWalker#next()` efficiency.


Additional information

No tests because the change does not change any logic.

@Reinmar
Copy link
Member

Reinmar commented Mar 28, 2022

It seems like a safe change – the _visitedParent value is used in the preceding two checks anyway so we can we quite certain about it being up to date in all cases.

@Reinmar Reinmar merged commit 23122e0 into master Mar 28, 2022
@Reinmar Reinmar deleted the cf/4467 branch March 28, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants