Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHS should ignore invalid attribute. #13923

Merged
merged 2 commits into from Apr 21, 2023
Merged

GHS should ignore invalid attribute. #13923

merged 2 commits into from Apr 21, 2023

Conversation

arkflpc
Copy link
Contributor

@arkflpc arkflpc commented Apr 19, 2023

Suggested merge commit message (convention)

Fix (engine): Editor should not crash when a custom element with an invalid attribute name is pasted. Closes #13841.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@arkflpc arkflpc requested a review from niegowski April 19, 2023 15:20
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix failing test in html-support package.

@arkflpc arkflpc merged commit 2389d30 into master Apr 21, 2023
3 checks passed
@arkflpc arkflpc deleted the ck/13841 branch April 21, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crashes if the attribute name is a number
2 participants