Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery: Export to PDF: text goes beyond its cell when columns are resized by resize handler #14379

Merged

Conversation

illia-stv
Copy link
Contributor

@illia-stv illia-stv commented Jun 13, 2023

Suggested merge commit message (convention)

Fix (table): Text will no longer go beyond its cell when columns are resized by resize handler in Firefox. Closes #14386.
Fix (export-pdf): Text will no longer go beyond its cell when columns are resized by resize handler in exported PDFs. Closes #3355.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@illia-stv illia-stv self-assigned this Jun 13, 2023
@illia-stv
Copy link
Contributor Author

illia-stv commented Jun 13, 2023

Let's have a look how Chrome display table with contenteditable and without:

Screenshot 2023-06-13 at 16 49 14

And compare it with how Firefox handle it:

Screenshot 2023-06-13 at 16 32 18

So as you see, chrome user-agent adds property overflow-wrap: break-word in case when its contenteditable.

Then it also explains why in firefox this is broken too:

image

So we just need to define css property overflow-wrap: break-word directly in table package

@Dumluregn
Copy link
Contributor

Let's merge it once QA team approves it and it gets R+ from our side.

@Dumluregn Dumluregn self-requested a review June 14, 2023 08:25
@mlewand
Copy link
Contributor

mlewand commented Jun 14, 2023

Thanks for the writeup @illia-stv - it surfaced one more thing that we didn't noted: currently (master branch) table content is rendered differently in Chrome & Firefox - that's also a bug.

This PR addresses this bug, so @illia-stv please search our issues list whether such bug has been already listed or not. If it wasn't reported, please report it.

Finally add this bug to list of closed issues by this PR.

Copy link
Contributor

@Dumluregn Dumluregn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Let's wait for QA team confirmation.

@Dumluregn
Copy link
Contributor

There's a green light from QAs 🟢

@Dumluregn Dumluregn merged commit a5908d4 into master Jun 16, 2023
1 check passed
@Dumluregn Dumluregn deleted the ck/3355-discovery-export-to-pdf-text-goes-beyond-the-cell branch June 16, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table content is rendered differently in Chrome & Firefox
3 participants