Added "@ckeditor/ckeditor-cloud-services-core" package to this repo

[pomek]

Suggested merge commit message (convention)

Internal: Added @ckeditor/ckeditor-cloud-services-core package to this repository. Closes #924.

---

Additional information

Requires:

• Introduced the "overrideDirectoryNames" option in a config cksource/mrgit#98 - allows overriding directories,
• Prepared package to add to ckeditor5 repository ckeditor-cloud-services-core#27 - preparing the repository (scripts, readme, etc.)

[Reinmar]

I don't lime the fact that we're renaming package which name starts with ckeditor- to ckeditor5-. In my original proposal in cksource/mrgit#72 I proposed to have a different directory structure, where all the prefixes (ckeditor5-*) are stripped. So, according to my comment, this setting here should be:

 "overrideDirectoryNames": {
      "@ckeditor/ckeditor5-cloud-services-core": "cloud-services-core"
  }

So, the actual directory name should be cloud-services-core.

[Reinmar]

See https://github.com/ckeditor/ckeditor5/pull/1467/files#r303510548. My proposal was to change all the names to get rid of any prefixes there. We can discuss if that's a good change, but this PR for now implements something else, hence R-.

[Reinmar]

cksource/mrgit#72 (comment)

[Reinmar]

I asked the team for a feedback on this and they see this a bit differently than I did:

So, we need to change our approach here a bit, unfortunately.

[Reinmar]

To adjust now:

• Docs (API + guides) => Prepared package to add to ckeditor5 repository ckeditor-cloud-services-core#27
• Manual tests and automatic tests => Adjusted dev tools to work with "ckeditor-" prefix ckeditor5-dev#554
• Release (Added "@ckeditor/ckeditor-cloud-services-core" package to this repo #1467 (comment))
• CI

Followups:

• Content styles (Added "@ckeditor/ckeditor-cloud-services-core" package to this repo #1467 (comment))
• Theme

[pomek]

Docs

I fixed as much as I could but I have no idea what to do with the errors below:

JSDoc started...
Incorrect param type: Blob
        at /Users/pomek/Projects/ckeditor/ckeditor5/packages/ckeditor-cloud-services-core/src/uploadgateway/fileuploader.js (line 29)

Incorrect param type: Blob
        at /Users/pomek/Projects/ckeditor/ckeditor5/packages/ckeditor-cloud-services-core/src/uploadgateway/uploadgateway.js (line 74)

Incorrect link: Token
        at /Users/pomek/Projects/ckeditor/ckeditor5/packages/ckeditor-cloud-services-core/src/token/token.js (line 150)

Invalid return type: Blob.                                                                                                                                                                                                                            at /Users/pomek/Projects/ckeditor/ckeditor5/packages/ckeditor-cloud-services-core/src/uploadgateway/fileuploader.js (line 248)


Validation Summary:
 * Validator found 4 errors.

Good news, #1978 will be resolved after adding the package to our repos.

[pomek]

Release tools

[pomek]

Content styles works. I don't remember what I should check in the "Theme" topic but if anything won't work, MT and Content styles scripts would print any error.

[pomek]

After merging PRs: ckeditor/ckeditor5-dev#554 and ckeditor/ckeditor-cloud-services-core#27, CI should work.

[pomek]

Error codes from the package are visible in the error table:

[pomek]

I found this:

[pomek]

Fixed.

[Reinmar]

(t/924 b7bb733 M1) p@m /workspace/ckeditor5> yarn test --files=cloud-services-core -c
yarn run v1.17.3
$ node --max_old_space_size=4096 node_modules/@ckeditor/ckeditor5-dev-tests/bin/test.js --files=cloud-services-core -c
TypeError: glob.match is not a function
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
(t/924 b7bb733 M1) p@m /workspace/ckeditor5>

[pomek]

@Reinmar, the error has been fixed (ckeditor/ckeditor5-dev@18feef7).