Extend range of drag-and-drop selection to fully selected parents #14891
Conversation
…-formatting-is-lost
…rage' into ck/14640-blockquote-formatting-is-lost
filipsobol
requested review from
niegowski
and removed request for
niegowski
…-formatting-is-lost
filipsobol
changed the title
|
When you drop content from caption outside widget it still stay there. So we should remember about that and create an issue for this bug. Manual.Test.-.14.September.2023.mp4 |
| * Because all elements inside the `blockQuote` are selected, the range includes the `blockQuote` too. | ||
| * If only first and second paragraphs would be selected, the range would not include it. | ||
| */ | ||
| function getRangeExtendedToLargestFullySelectedParent( model: Model, elements: Array<Element> ): Range { |
There was a problem hiding this comment.
To the getRangeExtendedToLargestFullySelectedParent we pass blocks, so maybe it could be good name for this argument instead elements, what do you think? To be honest I would call it selectedBlocks.
| * Because all elements inside the `blockQuote` are selected, the range includes the `blockQuote` too. | ||
| * If only first and second paragraphs would be selected, the range would not include it. | ||
| */ | ||
| function getRangeExtendedToLargestFullySelectedParent( model: Model, elements: Array<Element> ): Range { |
There was a problem hiding this comment.
This name is too long for me, maybe we could simplify it a little bit to getRangeExtendedToSelectedParent?
There was a problem hiding this comment.
I renamed it to getRangeIncludingFullySelectedParents as it better describes what this function does.
There was a problem hiding this comment.
I like it!!! But why parents and not parent?
There was a problem hiding this comment.
Because this function is recursive, so if first common parent doesn't have any siblings, its parent will also be included in the range and so on.
|
When you select blockquote with only part of paragraph it selects entire paragraph instead. Manual.Test.-.15.September.2023.mp4 |
Suggested merge commit message (convention)
Feature (clipboard): Extend drag-and-drop selection to parent elements when all their children are selected. Closes #14640.