CircleCI: Improved detecting a community PR #14901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2023
pomek
force-pushed
the
ci/improve-community-pr-detection
branch
from
67a1d76
to
e4d02da
Compare
|
As we can see, the detection step was executed initially, before bootstrapping the project. It did not fail. The change looks good, I think. |
pomek
pushed a commit
that referenced
this pull request
Sep 4, 2023
…tion Internal: CircleCI: Improved detecting a community PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: CircleCI: Improved detecting a community PR.
Additional information
is-community-pr.jsscript by removing theprocess.exit()parts.First commit contains enabled the coverage build for theCreating a PR to a feature branch does not trigger CI anymore.ci/improve-community-pr-detectionto see what happens if I create a PR from a forked repository.