Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline image resizing miscalculations / Resizing an image to make it smaller sometimes does the opposite #15821

Merged
merged 2 commits into from Feb 15, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Feb 9, 2024

Suggested merge commit message (convention)

Fix (image): Inline image resizing miscalculations / Resizing an image to make it smaller sometimes does the opposite. Closes #10267.

@Mati365 Mati365 marked this pull request as ready for review February 9, 2024 13:21
@charlttsie
Copy link
Contributor

I’ve checked how resizing images works on different browsers and with different inline and block images. The only thing I’ve noticed is the behaviour posted on Slack, so please take a look 👀 Besides that, the initial issue doesn’t reproduce and I haven’t spotted any regressions, so the fix looks good 🎉

@Witoso
Copy link
Member

Witoso commented Feb 12, 2024

Curious if in any way this improves this scenario: #14698

It was a long shot, I checked the code 😁

@Mati365 Mati365 changed the title Inline image resizing miscalculations / Resizing an image to make it smaller sometimes does the opposite #10267 Inline image resizing miscalculations / Resizing an image to make it smaller sometimes does the opposite Feb 14, 2024
@DawidKossowski DawidKossowski merged commit 44e3c43 into master Feb 15, 2024
6 checks passed
@DawidKossowski DawidKossowski deleted the ck/10267 branch February 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline image resizing miscalculations / Resizing an image to make it smaller sometimes does the opposite
4 participants