Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting a mention should not add extra white spaces #15867

Merged
merged 2 commits into from Feb 20, 2024

Conversation

oleq
Copy link
Member

@oleq oleq commented Feb 15, 2024

Suggested merge commit message (convention)

Fix (mention): Inserting a mention should not add an extra white space if there was one already. A white space should not follow a mention inserted in brackets. Closes #4651.


Additional information

In this PR I addressed two issues:

I think there are many improvements left related to inserting mentions in different places, for instance, I would expect "[] -> type a mention -> "@mention -> type " -> "@mention" but this one falls into text transformation category.

…one already. A mention inserted in brackets should not be followed by a white space.
@oleq oleq changed the title Inserting a mention should not add an extra white spaces Inserting a mention should not add extra white spaces Feb 15, 2024
@Dumluregn Dumluregn merged commit 048a6ce into master Feb 20, 2024
1 check passed
@Dumluregn Dumluregn deleted the ck/4651-mention-and-following-spaces branch February 20, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention should not add a white space if a position already followed by one
2 participants