#3233: Added model Position#findAncestor() and Element#findAncestor() methods #7598

niegowski · 2020-07-09T16:16:43Z

Suggested merge commit message (convention)

Feature (engine): Added model Position#findAncestor() and Element#findAncestor() methods. Closes #3233.

Internal (table): Removed findAncestor helper.

MINOR BREAKING CHANGE (table): The findAncestor() utility function was removed.

Additional information

jodator

Just one question about using element.is() after a second thought I don't see that needed and name === parentName is OK for me, WDYT?

packages/ckeditor5-engine/tests/model/element.js

packages/ckeditor5-engine/src/model/element.js

niegowski added 2 commits July 9, 2020 17:59

Added model Position#findAncestor() and Element#findAncestor() methods.

9a10205

Removed findAncestor() table helper.

aa535c1

niegowski requested a review from jodator July 9, 2020 16:16

jodator reviewed Jul 10, 2020

View reviewed changes

packages/ckeditor5-engine/tests/model/element.js Show resolved Hide resolved

packages/ckeditor5-engine/src/model/element.js Show resolved Hide resolved

jodator merged commit a349af5 into master Jul 13, 2020

jodator deleted the i/3233 branch July 13, 2020 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#3233: Added model Position#findAncestor() and Element#findAncestor() methods #7598

#3233: Added model Position#findAncestor() and Element#findAncestor() methods #7598

niegowski commented Jul 9, 2020

jodator left a comment

#3233: Added model Position#findAncestor() and Element#findAncestor() methods #7598

#3233: Added model Position#findAncestor() and Element#findAncestor() methods #7598

Conversation

niegowski commented Jul 9, 2020

Suggested merge commit message (convention)

Additional information

jodator left a comment

Choose a reason for hiding this comment