Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs paste plaintext #8316

Merged
merged 28 commits into from Nov 3, 2020
Merged

Docs paste plaintext #8316

merged 28 commits into from Nov 3, 2020

Conversation

godai78
Copy link
Contributor

@godai78 godai78 commented Oct 22, 2020

Closes cksource/ckeditor5-internal#414.

Adding plain text guide with demo. Presents the plain text paste and the special keyboard shortcut plain text paste with style inheritance.

Adding related features section to Paste plain text, Paste from Word, Paste from Google Docs.

Related features placeholder for raw HTML paste.

@AnnaTomanek
Copy link
Contributor

The stable branch cannot reference features that haven't been released.

See the following error that causes the CI to fail:

Error: Failed while convert {@link features/html-embed Raw HTML embedding} tag in ckeditor5/23.0.0/features/paste-from-google-docs.md.
Error: Failed while convert {@link features/html-embed Raw HTML embedding} tag in ckeditor5/23.0.0/features/paste-from-word.md.
Error: Failed while convert {@link features/html-embed Raw HTML embedding} tag in ckeditor5/23.0.0/features/paste-plaintext.md.

@AnnaTomanek AnnaTomanek requested a review from Mgsy November 2, 2020 14:20
@AnnaTomanek
Copy link
Contributor

I cleaned up the text a bit to make it more user-friendly as I don't think the general rumbling about Clipboard was useful to the end user. @Mgsy @FilipTokarski it would be great if you could help with the Installation section code as well as the snippet/build code.

@godai78
Copy link
Contributor Author

godai78 commented Nov 3, 2020

I restored the link removed previously. It would be nice to have this soon, as we want to mention it in the blogpost.

@Mgsy
Copy link
Member

Mgsy commented Nov 3, 2020

I've changed the editor config, reduced a list of plugins used in the build to only formatting-related plugins and added installation instruction for Clipboard plugin.

@godai78
Copy link
Contributor Author

godai78 commented Nov 3, 2020

Looks like this can finally fly.

@AnnaTomanek AnnaTomanek merged commit f5d118a into stable Nov 3, 2020
@AnnaTomanek AnnaTomanek deleted the docs-paste-plaintext branch November 3, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants