Reverted widespread editor.focus() usage back to editor.editing.view.focus() form #8414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s()" This reverts commit a8c8328.
…ation. Today we're always focusing the editable view, that's true - but at some point we might be focusing the UI parts.
|
I've added a bit more explanation to the |
|
And as I have this checked-out I might review this as well. |
# Conflicts: # packages/ckeditor5-widget/tests/widgetresize/_utils/utils.js
|
Sorry for the force-push... I've accidentally pushed my research on DLLs ( 😉 ). |
jodator
approved these changes
Nov 5, 2020
packages/ckeditor5-ui/docs/framework/guides/deep-dive/focus-tracking.md
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/docs/framework/guides/deep-dive/focus-tracking.md
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/docs/framework/guides/deep-dive/focus-tracking.md
Outdated
Show resolved
Hide resolved
Reinmar
reviewed
Nov 5, 2020
packages/ckeditor5-ui/docs/framework/guides/deep-dive/focus-tracking.md
Outdated
Show resolved
Hide resolved
Reinmar
reviewed
Nov 5, 2020
packages/ckeditor5-ui/docs/framework/guides/deep-dive/focus-tracking.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Revert: Reverted widespread
editor.focus()usage back toeditor.editing.view.focus()form. Closes #714.Additional information
Per #714 (comment) though
editor.focus()today always focuses the editing view - it's not said that it always will be.It also brings back
editor.editing.view.focus()mentions in the docs while also adding a mentioneditor.focus().