Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DLL modules to the global scope #8627

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Add DLL modules to the global scope #8627

merged 3 commits into from
Dec 10, 2020

Conversation

pomek
Copy link
Member

@pomek pomek commented Dec 10, 2020

Suggested merge commit message (convention)

Internal: DLL modules will be added to the global scope. Closes #8521.

@pomek pomek requested a review from jodator December 10, 2020 11:24
pomek
pomek commented Dec 10, 2020
View reviewed changes
scripts/dll/dll-loader.js Outdated Show resolved Hide resolved
jodator and others added 2 commits December 10, 2020 12:29
@jodator @pomek
Update scripts/dll/dll-loader.js
745c661 
Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
@jodator
Update documentation for new globals use.
6247660
jodator
jodator approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 👍 🎉

@jodator jodator merged commit a51150e into dll-integration Dec 10, 2020
@jodator jodator deleted the i/8521 branch December 10, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodator jodator jodator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pomek @jodator