Merge pull request #226 from ckeditor/i/209

Fixed the editor class name in the production build
ckeditor · Sep 4, 2020 · 52b3576 · 52b3576
2 parents bfea7be + b522544
commit 52b3576
Show file tree

Hide file tree

Showing 14 changed files with 54 additions and 2 deletions.
diff --git a/src/app/editor/editor.js b/src/app/editor/editor.js
@@ -76,8 +76,8 @@ export default class Editor {
 
 		this.domManipulator.addAttribute( root, 'data-github-writer-id', this.id );
 
-		// Add a class for this editor contructor, for easy to customize specific editors.
-		this.domManipulator.addClass( root, 'github-writer-' + this.constructor.name.toLowerCase() );
+		// Add a class for this editor type, for easy to customize specific editors.
+		this.domManipulator.addClass( root, 'github-writer-' + String( this.type ).toLowerCase() );
 
 		// Inject our classes in the dom. These will help controlling the editor through CSS.
 		this.domManipulator.addClass( this.dom.panels.markdown, 'github-writer-panel-markdown' );

diff --git a/src/app/features/codeditor.js b/src/app/features/codeditor.js
@@ -15,6 +15,10 @@ export default class CodeEditor extends Editor {
 		registerUpdateListener( this );
 	}
 
+	get type() {
+		return 'CodeEditor';
+	}
+
 	getDom( root ) {
 		const dom = super.getDom( root );
 

diff --git a/src/app/features/codelinecommenteditor.js b/src/app/features/codelinecommenteditor.js
@@ -8,6 +8,10 @@ import Editor from '../editor/editor';
 let listening = false;
 
 export default class CodeLineCommentEditor extends Editor {
+	get type() {
+		return 'CodeLineCommentEditor';
+	}
+
 	static run() {
 		if ( !listening ) {
 			// Code line comments: the "+" button...fires an event when the form for code comments is injected.

diff --git a/src/app/features/commenteditor.js b/src/app/features/commenteditor.js
@@ -7,6 +7,10 @@ import Editor from '../editor/editor';
 import { addClickListener } from '../modules/util';
 
 export default class CommentEditor extends Editor {
+	get type() {
+		return 'CommentEditor';
+	}
+
 	injectEditable( editable ) {
 		const container = this.createEditableContainer( editable );
 

diff --git a/src/app/features/milestoneeditor.js b/src/app/features/milestoneeditor.js
@@ -38,6 +38,10 @@ export default class MilestoneEditor extends Editor {
 		root.classList.add( 'github-writer-type-milestone' );
 	}
 
+	get type() {
+		return 'MilestoneEditor';
+	}
+
 	getDom( root ) {
 		const dom = super.getDom( root );
 

diff --git a/src/app/features/newcodeditor.js b/src/app/features/newcodeditor.js
@@ -14,6 +14,10 @@ export default class NewCodeEditor extends CodeEditor {
 		this._checkFileType();
 	}
 
+	get type() {
+		return 'NewCodeEditor';
+	}
+
 	_setInitialMode() {
 		super._setInitialMode( editorModes.MARKDOWN );
 	}

diff --git a/src/app/features/newcommenteditor.js b/src/app/features/newcommenteditor.js
@@ -6,6 +6,10 @@
 import Editor from '../editor/editor';
 
 export default class NewCommentEditor extends Editor {
+	get type() {
+		return 'NewCommentEditor';
+	}
+
 	getSizeContainer() {
 		return this.dom.root.querySelector( '.timeline-comment' );
 	}

diff --git a/src/app/features/newinlinecommenteditor.js b/src/app/features/newinlinecommenteditor.js
@@ -7,6 +7,10 @@ import Editor from '../editor/editor';
 import { addClickListener } from '../modules/util';
 
 export default class NewInlineCommentEditor extends Editor {
+	get type() {
+		return 'NewInlineCommentEditor';
+	}
+
 	getSizeContainer() {
 		return this.dom.root;
 	}

diff --git a/src/app/features/newissueeditor.js b/src/app/features/newissueeditor.js
@@ -6,6 +6,10 @@
 import Editor from '../editor/editor';
 
 export default class NewIssueEditor extends Editor {
+	get type() {
+		return 'NewIssueEditor';
+	}
+
 	static run() {
 		return this.createEditor( 'form#new_issue' );
 	}

diff --git a/src/app/features/newpullrequesteditor.js b/src/app/features/newpullrequesteditor.js
@@ -6,6 +6,10 @@
 import Editor from '../editor/editor';
 
 export default class NewPullRequestEditor extends Editor {
+	get type() {
+		return 'NewPullRequestEditor';
+	}
+
 	static run() {
 		return this.createEditor( 'form#new_pull_request' );
 	}

diff --git a/src/app/features/releaseeditor.js b/src/app/features/releaseeditor.js
@@ -6,6 +6,10 @@
 import Editor from '../editor/editor';
 
 export default class ReleaseEditor extends Editor {
+	get type() {
+		return 'ReleaseEditor';
+	}
+
 	getDom( root ) {
 		const dom = super.getDom( root );
 		delete dom.toolbar;

diff --git a/src/app/features/revieweditor.js b/src/app/features/revieweditor.js
@@ -6,6 +6,10 @@
 import Editor from '../editor/editor';
 
 export default class ReviewEditor extends Editor {
+	get type() {
+		return 'ReviewEditor';
+	}
+
 	static run() {
 		return this.createEditor( 'div.pull-request-review-menu > form' );
 	}

diff --git a/src/app/features/savedreplyeditor.js b/src/app/features/savedreplyeditor.js
@@ -6,6 +6,10 @@
 import Editor from '../editor/editor';
 
 export default class SavedReplyEditor extends Editor {
+	get type() {
+		return 'SavedReplyEditor';
+	}
+
 	static run() {
 		return this.createEditor( 'form.new_saved_reply, form.edit_saved_reply' );
 	}

diff --git a/src/app/features/wikieditor.js b/src/app/features/wikieditor.js
@@ -6,6 +6,10 @@
 import Editor from '../editor/editor';
 
 export default class WikiEditor extends Editor {
+	get type() {
+		return 'WikiEditor';
+	}
+
 	getDom( root ) {
 		const dom = super.getDom( root );