Add StringBuilder.appendCodePoint
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Jan 23, 2023
| * The length of this sequence increases by [CodePoints.charCount]. | ||
| * | ||
| * The overall effect is exactly as if the argument were converted to a char array by the function | ||
| * [CodePoints.toChars] and the characters in that array were then appended to this sequence. |
There was a problem hiding this comment.
Note that this referenced function here doesn't exist yet. These are the adapted docs from Java which seems to be what you were doing with the others.
I can add it next.
|
Can rebase over #7 if you want to land that first. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8