Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding stagingRelease #52

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Allow overriding stagingRelease #52

merged 1 commit into from
Mar 13, 2023

Conversation

nightscape
Copy link
Contributor

This allows using the plugin for the open-source version of Nexus (which does not support staging) as well, e.g. internal Nexus repos.

ckipp01
ckipp01 requested changes Mar 10, 2023
View reviewed changes
Copy link
Owner

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @nightscape! It looks like formatting is failing. Are you able to fix that? Also, can you add a small section about this in the readme? Probably right before the How does this differ from just using Mill? section.

@nightscape nightscape force-pushed the feat/configurable-staging-release branch 2 times, most recently from fa9e3df to cc30e46 Compare March 13, 2023 08:42
@nightscape nightscape force-pushed the feat/configurable-staging-release branch from cc30e46 to 267e6cb Compare March 13, 2023 08:44
@nightscape
Copy link
Contributor Author

Hi @ckipp01, I fixed the formatting issue and put a section into the README.
Good to go from my side 😃

ckipp01
ckipp01 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Owner

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM!

Thanks @nightscape!

@ckipp01 ckipp01 merged commit f53626a into ckipp01:main Mar 13, 2023
@ckipp01
Copy link
Owner

ckipp01 commented Mar 13, 2023 •
edited
Loading

So this merge created 0.1.5-19-f53626-SNAPSHOT. Can you give that a shot @nightscape and double-check that it all works as expected? If so, I can go ahead and cut a new stable release.

@nightscape
Copy link
Contributor Author

@ckipp01 unfortunately the project in which I used this has ended last Friday and I don't have access to that Nexus instance anymore.
But I had successfully used my (JitPack'ed) version of the code while I was on the project.

@nightscape nightscape deleted the feat/configurable-staging-release branch March 13, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nightscape @ckipp01