fix: ensure properties are correctly resolved #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change only the maven properties were actually resolved leaving the rest not. This would cause for example `$package$` to end up being generated as `$package`. Now we ensure everything that we can is resolved by mimicking the way it's done in the sbt plugin. NOTE: I still plan on improving this a bit by allowing the user to pass in values to validate/generate which can be used to generate with specific values. Closes #11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change only the maven properties were actually resolved
leaving the rest not. This would cause for example
$package$to end upbeing generated as
$package. Now we ensure everything that we can isresolved by mimicking the way it's done in the sbt plugin.
NOTE: I still plan on improving this a bit by allowing the user to pass
in values to validate/generate which can be used to generate with
specific values.
Closes #11