-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative syntax for 'deftemplate' and 'defsnippet' #13
Comments
Not sure you can use meta like this with a macro but a map instead of key word for options I think is a brilliant idea. It gives us a syntax that is expandable without having to change the basic structure. |
Turns out you actually can use metadata in macros calls: user=> (defmacro deftemplate [name & _] (pr-str (meta name)))
#'user/deftemplate
user=> (macroexpand-1 '(deftemplate ^:private foo))
"{:private true}" |
Were you doing this in a clojurescript repl? If not can you try it in a clojurescript repl. Not all the information you normally get in clojure is passed by the clojurescript compiler during macro expansion. If we can do this that would be great. If the clojurescript repl does not work, I can work on adding to the clojurescript compiler. I already have to add sending the namespace of symbols. |
Nope, that was a Clojure repl, here's a ClojureScript example: ;; macros.clj
(defmacro deftemplate [name & _]
`(.log js/console (pr-str ~(meta name))))
;; test.cljs
(deftemplate ^:private foo) When I try this, I see |
That is great, I like this a lot better than the :compile :remote setup we CK On Thu, Jun 7, 2012 at 4:39 PM, Sergei Lebedev <
|
The more I think about this the more I love it! Its clean, doesn't affect the syntax of the macro and can be extended easily. If I get some time this weekend I will take a crack at this, unless you are already implementing something. |
One more thing we need to decide on: do we allow passing metadata to the generated functions, or is it enfocus-only? |
I've created a feature/metadata branch in my fork. |
@superbobry I noticed in your branch you have the location as part of the meta data. I would like to keep the syntax as consistent as possible. The location is a required part and should remain as part of the normal syntax where as private and compiled are optional inputs best left in the meta data. What you got so far looks great, I am thinking about moving towards 1.0 release and would love to have this be part the first release. I have finished up quite a bit of the Domina migration and If you want to concentrate on this I can take a look at the event stuff. Thanks again for helping out with Enfocus it is very appreciated! CK |
I was thinking -- maybe we can use metadata notation for defining
:compiled
templates and snippets? this will allow creating private templates, ex:The text was updated successfully, but these errors were encountered: