Added tests to demonstrate poor performance on Safari (also applies in Phantom.js) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.cljs) which crashes the test-runner! Hmm.
…kely cause of the issue Added identical tests to om & reagent test suites; executes without difficulty in Om but causes Phantom.js to crash in reagent Commented out the reagent test as it's not a fun test to run automatically on every change
|
Thank you for this! |
ckirkendall
added a commit
that referenced
this pull request
Sep 6, 2015
Added tests to demonstrate poor performance on Safari (also applies in Phantom.js)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a sample html file and identical tests to the Om and reagent test files to show how the issue applies only when using Kioo with Reagent.
I commented out the reagent test as it causes Phantom.js to fall over rather than crash gracefully or quickly, which can be pretty annoying when continuously testing.