Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiplication and division by a float precision #127

Merged

Conversation

marwins
Copy link
Contributor

@marwins marwins commented Sep 1, 2022

No description provided.

@ricardogobbosouza
Copy link
Member

Hi @marwins
Could you add some tests?

@marwins
Copy link
Contributor Author

marwins commented Oct 26, 2022

Hi @ricardogobbosouza thanks.
I fixed tests that were not passing due to the fix and added some concerning the issue

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #127 (dc66601) into main (2bacfb2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #127   +/-   ##
=========================================
  Coverage     99.15%   99.15%           
  Complexity      158      158           
=========================================
  Files            16       16           
  Lines           355      355           
=========================================
  Hits            352      352           
  Misses            3        3           
Impacted Files Coverage Δ
src/Money.php 96.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ricardogobbosouza ricardogobbosouza merged commit 13a87ac into cknow:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants