Fill the Currrency Field without checking #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dears,
During my development i found that the currency fields doesn't get filled with new instances and i have to fill the currency manually
i checked the code and it seems that it checks if the field exists in the attribute before filling which for new instances wouldn't be correct.
so i don't think we need to do the check as it's already passed as a parameter.
For anyone facing the same issue you can just initialize the currency field using attributes inside the model