Skip to content

Commit

Permalink
Merge pull request #6 from sherifzain/truncate-values
Browse files Browse the repository at this point in the history
Truncate values before evaluation
  • Loading branch information
cknv committed May 30, 2018
2 parents 64ee517 + 3a84431 commit d211d2d
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
2 changes: 1 addition & 1 deletion envargs/parser.py
Expand Up @@ -22,7 +22,7 @@ def _load_values(values, fields):
yield dest, field.default

else:
value = field.parse(value, location)
value = field.parse(value.strip(), location)
field.validate(value, location)
yield dest, value
elif isinstance(field, dict):
Expand Down
26 changes: 26 additions & 0 deletions tests/test_parsing.py
Expand Up @@ -232,3 +232,29 @@ def test_nesting():
'an_int': 10,
},
}


def test_numeric_var_with_spaces():
"""Test that numbers are parsed properly even if they have spaces."""
args = {
'an_int': Var(use=int, load_from='AN_INT',),
}

os.environ['AN_INT'] = '0 '

assert parse_env(args) == {
'an_int': 0,
}


def test_string_var_with_spaces():
"""Test that string values are truncated."""
args = {
'a_var': Var(use=str, load_from='A_VAR',),
}

os.environ['A_VAR'] = ' username\n'

assert parse_env(args) == {
'a_var': 'username',
}

0 comments on commit d211d2d

Please sign in to comment.