Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile attachments (and a way of updating followers with new profile info) #190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TomCasavant
Copy link
Contributor

@TomCasavant TomCasavant commented Apr 12, 2024

Addresses #189

I didn't add any styles to the new profile fields, so here's what they look like right now:
image

And then as of right now the only way I have to update current followers with this any new profile updates is to uncomment this line in server.js (EDIT: Moved updateProfile call to fix linting issues)

//updateProfile(account, domain)

image

I have it commented it out by default because I assume we don't want to send a message to every follower whenever the server boots up (and eventually I assume we'll have a way to update your profile from the admin page? In which case we'd just trigger updateProfile whenever that gets changed)

Maybe this belongs in a different issue/feature request but I was thinking since we already have a variable for the mastodon account we could probably include that as a profile field by default if it exists

Lastly, I just noticed this as I was making this PR, in this current setup it adds up profile updates in the total post count, that gets fixed if I modify this function to:

export async function getMessageCount() {
  return (await db?.get('select count(message) as count from messages where bookmark_id is not null'))?.count;
}

But I'd like clarification on if I'm storing these activities/updates in the right spot in the database or if there are any other non-bookmark activities that we are already storing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant