4.14 ck1 additions #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an IO scheduler is selected via elevator= and it doesn't match the driver in question wrt blk-mq support, then we fail to boot. The elevator= parameter is deprecated and only supported for non-mq devices. Augment the elevator lookup API so that we pass in if we're looking for an mq capable scheduler or not, so that we only ever return a valid type for the queue in question. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=196695 Reviewed-by: Omar Sandoval <osandov@fb.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
https://github.com/Algodev-github/bfq-mq add bfq-sq the bfq pre mainline integration so SQ devices can use bfq again.
Since we now lookup elevator types with the appropriate multiqueue capability, allow schedulers to register with an alias alongside the real name. This is in preparation for allowing 'mq-deadline' to register an alias of 'deadline' as well. Reviewed-by: Omar Sandoval <osandov@fb.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
based upon https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/block/elevator.c?id=8ac0d9a81edf2ef4a2268b65b802a6b856dc77e6 add bfq as an alias for bfq-sq and deadline for mq-deadline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for pushing to the wrong branch previously.
811cb39 fixes an OOPS elevator=bfq/kyber/mq-deadline and queue is SQ.
This was the OOPS that hit linux-ck users in 4.12 and 4.13 who were used to using elevator=bfq
now in mainline as 2527d99 not planned for stable backport.
If you wanted to add back support for bfq to SQ device users that rest of the series is aimed at that.
Second is the BFQ-MQ series https://github.com/Algodev-github/bfq-mq adding back BFQ support under the name bfq-sq for SQ devices.
1588e6b add alias support for elevators now in mainline as 8ac0d9a
df2a75f use the alias support to add an alias of bfq for bfq-dq and deadline for mq-deadline,
mq-deadline alias now in mainline as 4d740bc
Fifth remove an upstream check preventing MQ devices being set by the elevator parameter.