-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build failed on macos #204
base: master
Are you sure you want to change the base?
Conversation
@@ -59,5 +59,9 @@ $(ASM_7z).lo: $(ASM_S) | |||
$(ASM_PROG) $(ASM_OPT) -o $(ASM_7z).o $(ASM_S) | |||
mkdir -p .libs | |||
cp $(ASM_7z).o .libs/ | |||
@echo -e "$(7ZIPASMLOFILE)" > $(ASM_7z).lo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo -e
is not portable. some shell not support this argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not do this. the .lo file is needed to build the library in lrzip 0.641
. Perhaps the cat
command could be used. Mac users have compiled lrzip successfully. The echo -e
command allows escape characters to print to the output. Perhaps try hard coding /usr/bin/echo since shells are not guaranteed to work the same way as the bin.
@@ -1,4 +1,4 @@ | |||
SUBDIRS = C ASM/x86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ASM/x86
have been handled in C submodule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK who added this. But if you do this, you'll have to make sure there is nothing in the x86 dir that IS needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanna successfully build lrzip 0.641
. I don't wanna change too much.
Generally, people who package |
the macOS user can't build |
Just do |
I'm not just removing |
Glad it works for you. Certain shells do not support all |
Suggested-at: ckolivas/lrzip#204 (comment) Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Suggested-at: ckolivas/lrzip#204 (comment) Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Suggested-at: ckolivas/lrzip#204 (comment) Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
* abyss & btllib: add linux-aarch64 build Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> * lrzip: add linux-aarch64 build Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> * Update lrzip to 0.651 that supports Linux ARM64 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> * Run autogen.sh for lrzip Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> * Add `autoconf` to the build requirements Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> * Add `automake` to the build requirements Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> * Add `libtool` to the build requirement Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> * Pass `--disable-asm` for Mac OSX Suggested-at: ckolivas/lrzip#204 (comment) Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> * Disable build for osx * Bump build number --------- Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
close #203