Clang-Tidy #143
Clang-Tidy #143
Conversation
johnmcfarlane
force-pushed
the
clang-tidy
branch
2 times, most recently
from
4b4d1ac
to
6b5c348
Compare
|
Hi @johnmcfarlane is there a list of syntax issues I need to address. Briefly looking at the reduced set of CI jobs, I can not find any syntax checking output? |
|
Once this change is working, failing checks will be reported in the logs -
as with other tools such as the compiler. For now it's a draft. Other jobs
are commented out.
…On Sun 21 Nov 2021, 08:26 Christopher Kormanyos, ***@***.***> wrote:
Hi @johnmcfarlane <https://github.com/johnmcfarlane> is there a list of
syntax issues I need to address. Briefly looking at the reduced set of CI
jobs, I can not find any syntax checking output?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFTGN7WJVNZOH7ZCDMUGGTUNCUL3ANCNFSM5IOYKSGQ>
.
|
johnmcfarlane
force-pushed
the
clang-tidy
branch
26 times, most recently
from
ffd6b2a
to
5af384d
Compare
johnmcfarlane
force-pushed
the
clang-tidy
branch
4 times, most recently
from
8decd16
to
8182415
Compare
johnmcfarlane
force-pushed
the
clang-tidy
branch
4 times, most recently
from
51bd2f3
to
6a15623
Compare
@ckormanyos here's a job with all of the checks turned on. It hasn't started yet but it'll be quite a list! Many of completely trivial to fix. Some are not worth fixing at all and can remain exceptions (with a But for the rest of the checks, I would suggest removing the exception and fixing the resultant pipeline failures one-by-one. They can make good pieces of work to do in an idle moment or if someone volunteers to help out. I'd be happy to take a few myself in the interest of harmonising with CNL. It's easy to search for the checks online for an explanation of what the problem is/how to fix it and there's a complete list here. |
johnmcfarlane
force-pushed
the
clang-tidy
branch
from
6a15623
to
cd073c4
Compare
|
Thank you @johnmcfarlane there are a couple of nuggets in there. I also enjoy the numerous messaages regarding modernization. It is nice to see some metric information and some rudimentary loop analysis --- a thousand new things to do that actually improve the code base |
|
See also #145 |
Add a clang-11 job with Clang-Tidy enabled
Clang-Tidy performs static analysis on the library. However, assuming it hasn't been run on wide-integer before, it is likely to emit a large quantity of diagnostics.