Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: basic implementation for Dependency Track #25

Merged
merged 5 commits into from
Feb 1, 2022
Merged

feat: basic implementation for Dependency Track #25

merged 5 commits into from
Feb 1, 2022

Conversation

derkoe
Copy link
Contributor

@derkoe derkoe commented Jan 31, 2022 •
edited

This adds a basic implementation for sending data to Dependency Track.

When launching the operator make sure to also set --format=cyclonedx

This is how the Dependency Track project is found:

  • Search for project with the property "image-name" in the group "container" with the image name
  • If found use this project, if not found create a new project with the image name as the project name + also add the property "image-name"

See #5

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2022
@ckotzbauer ckotzbauer added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 31, 2022
ckotzbauer
ckotzbauer reviewed Jan 31, 2022
View reviewed changes
Copy link
Owner

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @derkoe for this PR! I left some comments for discussion.
What about this comment #5 (comment) from @pmckeown? I think the folks who are knowing DT can better discuss on this 😆

internal/config.go Outdated Show resolved Hide resolved
internal/target/dtrack_target.go Outdated Show resolved Hide resolved
internal/target/dtrack_target.go Outdated Show resolved Hide resolved
internal/target/dtrack_target.go Outdated Show resolved Hide resolved
@derkoe
Load all projects with paging
ee52f3a
@derkoe
Fixed typos Dependenca -> Dependency
d261a4f
@derkoe
feat: add version, use project auto-creation
02e036d 
With this change the SBOM is now just uploaded to Dependency Track with
the "auto-creat" option set to true. So, each project/version combinations
gets an entry in Dependency Track.

The Docker repository (registry + image) is used as the project name, the
Docker tag is used for the version.
ckotzbauer
ckotzbauer reviewed Jan 31, 2022
View reviewed changes
Copy link
Owner

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two comments from my side, I like the simplified implementation! 🎉

internal/target/dtrack_target.go Outdated Show resolved Hide resolved
internal/target/dtrack_target.go Outdated Show resolved Hide resolved
pmckeown
pmckeown approved these changes Feb 1, 2022
View reviewed changes
Copy link

@pmckeown pmckeown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TGTM 👍

internal/target/dtrack_target.go Show resolved Hide resolved
internal/target/dtrack_target.go Show resolved Hide resolved
@ckotzbauer ckotzbauer merged commit 43c8401 into ckotzbauer:main Feb 1, 2022
@ckotzbauer
Copy link
Owner

Thanks to everyone who has contributed here 🎉
Now only the README docs (under the target-section) need to be enhanced with the general behaviour and specifics (e.g. cyclonedx as format). I can add this in the next few days, but if anyone has time to do a PR, this would be great :)

@derkoe derkoe mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro left review comments

@pmckeown pmckeown pmckeown approved these changes

@ckotzbauer ckotzbauer ckotzbauer approved these changes

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@derkoe @ckotzbauer @pmckeown @nscuro