fix: add retry to kubernetes.UpdatePodAnnotation #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will compensate for optimistic lock errors during the update of pod annotations
mycrEEpy
changed the title
github-actions
bot
added
the
size/S
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 25.69% 25.41% -0.29%
==========================================
Files 6 6
Lines 537 543 +6
==========================================
Hits 138 138
- Misses 383 389 +6
Partials 16 16
☔ View full report in Codecov by Sentry. |
ckotzbauer
approved these changes
Jul 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a very simple retry logic around to the kubernetes.UpdatePodAnnotation function.
Motivation
When updating a pods annotation the pod may have already been updated by some other process (e.g. a service mesh) in the meantime resulting in an optimistic lock error.
Alternative
We could also use a patch operation instead of an update operation to prevent the optimistic lock error.